Conversation
Users with email addresses not ending in gov.uk were experiencing errors when trying to provide a Welsh translation for their form because their support email was valid for the English version but not the Welsh version. This was happening even though both `support_email` and `support_email_cy` used the `allowed_domains` validator because the Welsh translation input object wasn't exposing the current user to the validator. This commit fixes this so that things work as expected.
lfdebrux
force-pushed
the
ldeb-fix-welsh-translation-input-allowed-email-domain-validator
branch
from
67b9665 to
78ea68c
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2745.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
DavidBiddle
approved these changes
May 1, 2026
lfdebrux
deleted the
ldeb-fix-welsh-translation-input-allowed-email-domain-validator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Users with email addresses not ending in gov.uk were experiencing errors when trying to provide a Welsh translation for their form because their support email was valid for the English version but not the Welsh version (see https://govuk.zendesk.com/agent/tickets/6565015).
This was happening even though both
support_emailandsupport_email_cyused theallowed_domainsvalidator because the Welsh translation input object wasn't exposing the current user to the validator.This PR fixes the validation so that it works as expected.
Things to consider when reviewing